ftwall build broke FC1 tcp.h (glibc-kernheaders)

[Warren Togami]

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=109474
Filed.

On Fri, 2003-11-07 at 12:28, Roland McGrath wrote:
> I think those glibc-kernheaders changes are broken.  htonl is not a valid
> constant expression macro in userland, though it might now be in
> kernelland.  The userland macro will be optimized away to the constant by
> the compiler, but that does not make it a valid constant expression.
> 
> Could you file a report against the FC glibc-kernheaders package on
> bugzilla.redhat.com?
> 
> 
> Thanks,
> Roland
> 
> 
> 
> > --- tcp.h-rh9   2003-11-06 21:45:40.000000000 -1000
> > +++ tcp.h-fc1   2003-11-06 21:46:08.000000000 -1000
> > @@ -102,16 +102,16 @@
> >  #define tcp_flag_word(tp) ( ((union tcp_word_hdr *)(tp))->words [3])
> >   
> >  enum {
> > -       TCP_FLAG_CWR = __constant_htonl(0x00800000),
> > -       TCP_FLAG_ECE = __constant_htonl(0x00400000),
> > -       TCP_FLAG_URG = __constant_htonl(0x00200000),
> > -       TCP_FLAG_ACK = __constant_htonl(0x00100000),
> > -       TCP_FLAG_PSH = __constant_htonl(0x00080000),
> > -       TCP_FLAG_RST = __constant_htonl(0x00040000),
> > -       TCP_FLAG_SYN = __constant_htonl(0x00020000),
> > -       TCP_FLAG_FIN = __constant_htonl(0x00010000),
> > -       TCP_RESERVED_BITS = __constant_htonl(0x0FC00000),
> > -       TCP_DATA_OFFSET = __constant_htonl(0xF0000000)
> > +       TCP_FLAG_CWR = htonl(0x00800000),
> > +       TCP_FLAG_ECE = htonl(0x00400000),
> > +       TCP_FLAG_URG = htonl(0x00200000),
> > +       TCP_FLAG_ACK = htonl(0x00100000),
> > +       TCP_FLAG_PSH = htonl(0x00080000),
> > +       TCP_FLAG_RST = htonl(0x00040000),
> > +       TCP_FLAG_SYN = htonl(0x00020000),
> > +       TCP_FLAG_FIN = htonl(0x00010000),
> > +       TCP_RESERVED_BITS = htonl(0x0FC00000),
> > +       TCP_DATA_OFFSET = htonl(0xF0000000)
> >  };
> >   
> >  /* TCP socket options */