submitters +1ing their own packages

[Peter Hutterer]

On Tue, Sep 06, 2011 at 07:38:53PM -0700, Adam Williamson wrote:
> On Wed, 2011-09-07 at 11:00 +1000, Peter Hutterer wrote:
> > On Tue, Sep 06, 2011 at 05:02:25PM -0700, Adam Williamson wrote:
> > > I've mentioned before that I actually support this, but I'm in the
> > > minority, and AFAIK the current policy is supposed to be that
> > > maintainers cannot upkarma updates they submitted themselves. However,
> > > this seems to be happening - exhibit a):
> > > 
> > > https://admin.fedoraproject.org/updates/nss-3.12.10-7.fc16
> > > 
> > > karma is listed as 1, the only positive feedback shown as I write this
> > > is from kengert, who submitted the update.
> > > 
> > > Is this a Bodhi bug? Or does FESCo expect voluntary compliance /
> > > case-by-case enforcement of this policy?
> > 
> > sometimes a +1 after weeks in testing is the only or at least easy way to
> > nudge a package into stable.
> > 
> > e.g: https://admin.fedoraproject.org/updates/libXi-1.4.3-2.fc15
> > even with my +1 still not there, and this isn't the only package I've done
> > this for.
> 
> Please don't turn this into another 'I'm not getting enough testing on
> my old critpath package' thread. We already have about five of those,

that wasn't my intent.

> plus a trac ticket. Whether it has some practical effect or not, it's
> clearly against the current policy, and what I'm questioning is whether
> Bodhi should be enforcing that policy automatically.

my argument is that even though it's against official policy, it can be
useful in some cases. The current voluntary compliance is imo a good
solution since it can be circumvented when needed. I'm definitely not
advocating doing this for every update.

Cheers,
  Peter