Package Review Request: python-picloud

Amit Saha droidery at
Tue Mar 6 13:21:16 UTC 2012

On 03/06/2012 09:07 PM, Paul Howarth wrote:
> On 03/06/2012 03:11 AM, Vijay N. Majagaonkar wrote:
>> Please, no! %{__cp} hugely decreases readability and if the
>> situation happens that mkdir and cp are not in the $PATH we will
>> have much bigger problems than running sed on all .spec files.
>> I am sorry but this will hit even if you don't use macro when tools are
>> not in $PATH, unless you use full path
>> Use just plain Unix commands as $DEITY intended them to be used.
>> I believe macro give you plain Unix command with full path.
> It does, but the current packaging guidelines say not to use these macros:
> "Macro forms of system executables SHOULD NOT be used except
> when there is a need to allow the location of those executables
> to be configurable. For example, rm should be used in preference
> to %{__rm}, but %{__python} is acceptable."
> When reviewing a package, you need to be familiar with the guidelines
> and not suggest changes that are in contradiction with them.

Thanks for the clarifications and comments. Will it sound like begging 
if I call out for someone to review this, please?

Thanks much!


More information about the devel mailing list