Evolving standards for unpacked sources

Adam Jackson ajax at redhat.com
Wed May 30 16:13:42 UTC 2012

On 5/30/12 9:33 AM, Peter Jones wrote:

> diff --git a/ocaml.spec b/ocaml.spec
> index bbf2669..2ab0ecc 100644
> --- a/ocaml.spec
> +++ b/ocaml.spec
> @@ -233,9 +233,13 @@ man pages and info files.
> git init
> git config user.email "noone at example.com"
> git config user.name "no one"
> +git config sendemail.to "%{name}-owner at fedoraproject.org"
> git add .
> git commit -a -q -m "%{version} baseline"
> git am %{patches}

Sorry for the hijack, but this should be written as:

git am %{patches} < /dev/null

Otherwise in the admittedly lovely case where you have no patches to 
apply, your package will build in mock (because the standard fds are 
already thus redirected) but normal fedpkg commands will hang.

- ajax

More information about the devel mailing list