[Bug 979566] Review Request: mingw-postgresql - MinGW Windows PostgreSQL library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=979566

Sandro Mani <manisandro at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #1 from Sandro Mani <manisandro at gmail.com> ---
Issues:
- Use macros instead of hardcoded path names, i.e.
rm $RPM_BUILD_ROOT/usr/i686-w64-mingw32/sys-root/mingw/bin/*.exe
-> rm $RPM_BUILD_ROOT%{mingw32_bindir}/*.exe

- I would use %{_builddir}/%{buildsubdir} instead of the relative paths when
creating the symlinks:
ln -s %{_builddir}/%{buildsubdir}/src/interfaces/libpq/libpqdll.def
./build_win32/src/interfaces/libpq/
etc
(Maybe add a comment on why the links are necessary? Package seems to build
also without the links, though I have not verified its functionality)

- Nitpicking: fedora-review says:
  Note: These BR are not needed: gawk
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

Rest looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cXn6mvkAM3&a=cc_unsubscribe