[Bug 984248] Review Request: mingw-shapelib - MinGW Windows shapelib library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=984248

--- Comment #1 from Michael Cronenworth <mike at cchtml.com> ---
+ OK
! needs attention

+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
! The license field in the spec file matches the actual license
+ The stated license is the same as the one for the corresponding
  native Fedora package
! The package contains the license file (COPYING.lib)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  2ff7d0b21d4b7506b452524492795f77  Downloads/shapelib-1.3.0.tar.gz
  2ff7d0b21d4b7506b452524492795f77  SOURCES/shapelib-1.3.0.tar.gz
! The package builds in koji
n/a ExcludeArch bugs filed
! BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
Not applicable to MinGW packages.
+ Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
+ Packages must not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8

-----
Summary:
- BR for mingw64-proj, package does not exist.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=5605993
- License is missing GPLv2 and Public Domain
  contrib/csv2shp.c: GPL (v2 or later)
  contrib/dbfinfo.c: Public domain
  contrib/dbfcat.c: Public domain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kEVMi2Vqao&a=cc_unsubscribe