[Bug 1137021] Review Request: monofett-fonts - Monofett fonts released by Vernon Adams
bugzilla at redhat.com
bugzilla at redhat.com
Tue Sep 9 16:08:29 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1137021
--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> ---
We got naming issue resolved as "we don't need to add `google-` prefix".
Review:
+ Package builds fine in mock in F22
- rpmlint on generated rpms gave output
monofett-fonts.src: E: specfile-error warning: line 61: second %files
2 packages and 0 specfiles checked; 1 errors, 0 warnings.
- source verified with upstream as (sha256sum)
=> Don't know how to download source archive
+ License is OFL and included in its own text file OFL.txt
- fontconfig file looks good
+ follows fonts packaging guidelines except additional %files
Suggestions:
1) if you execute
rpm -E %_font_pkg
you will see this macro already added %files. so you should remove %files
written explicitly in spec file.
2) How do you created source archive? Maybe you should add comment above
Source0: tag and write how one can obtain same tarball
3) and version looks 1.000 and not 1.00
4) URL: should be https://www.google.com/fonts/specimen/Monofett
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PsWSPbazpq&a=cc_unsubscribe
More information about the fonts-bugs
mailing list