[Fedora-i18n-bugs] [Bug 801058] Review Request: fcitx-cloudpinyin - Cloudpinyin module for fcitx

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=801058

--- Comment #3 from Liang Suilong <liangsuilong at gmail.com> ---
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-cloudpinyin.spec
SRPM:
http://liangsuilong.fedorapeople.org/fcitx/fcitx-cloudpinyin-0.2.1-1.fc16.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4091875


(In reply to comment #1)
> Review:-
> + koji scratch build for f17 ->
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4024897
> 
> + rpmlint on rpms gave
> fcitx-cloudpinyin.src: W: spelling-error %description -l en_US Cloulpinyin
> -> Cloudiness
> fcitx-cloudpinyin.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
> tab: line 5)
> fcitx-cloudpinyin.src: W: invalid-url Source0:
> http://fcitx.googlecode.com/files/fcitx-cloudpinyin-0.2.0.tar.bz2 HTTP Error
> 404: Not Found
> fcitx-cloudpinyin.x86_64: W: spelling-error %description -l en_US
> Cloulpinyin -> Cloudiness
> 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
> 
> + Source verified with upstream as (sha1sum)
> d9337b344fbefde61689e0a5aa9f54530a6b6c71  fcitx-cloudpinyin-0.2.0.tar.bz2
> d9337b344fbefde61689e0a5aa9f54530a6b6c71 
> ../SOURCES/fcitx-cloudpinyin-0.2.0.tar.bz2
> 
> + Package : fcitx-cloudpinyin-0.2.0-1.fc17.x86_64
> Provides: fcitx-cloudpinyin.so()(64bit)
> Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libcurl.so.4()(64bit) rtld(GNU_HASH)
> 
> Suggestions:-
> 1) Fix the rpmlint messages. 
>   a) mixed-use-of-spaces-and-tabs message can be fixed using command
>      sed -i 's|\t| |g' fcitx-cloudpinyin.spec
>   b) description lines should be of 80 characters.

Fixed.

> 
> 2) If package is only for Fedora then no need to add
>   a) %clean section (see
> http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
>   b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
>   c) remove line %defattr(-,root,root,-)
> 

The packages will support EL-6
> 3) please don't use commands in macro that is change %{__mkdir} to "mkdir"
> 

Fixed

> 4) package should add Requires: fcitx, fcitx-data
> 

Fixed, add fcitx only

> 5) Use following commands in %build
> %cmake ..
> make VERBOSE=1 %{?_smp_mflags}
> 
Fixed

> 6) %install should preserve timestamp using 
>    make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
>

Fixed

> 7) Add COPYING to %doc

Fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/i18n-bugs/attachments/20120521/670e71f0/attachment-0001.html>