[MERGE] Fixing errors found with ReviewBoard integration
Stephen Gallagher
sgallagh at redhat.com
Tue Feb 16 17:56:49 UTC 2010
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
The attached patch resolves the following issues that were interfering
with FAS integration in ReviewBoard.
django/auth/middleware.py:
If there are other authentication mechanisms in place, don't throw
an exception on a missing session_id
django/auth/models.py:
connection.group_list returns a tuple, the second entry of which is
the dict that we intended to be accessing. Trying to call
gl['groups'] throws a KeyError
userinfo in _get_name() contains a double-level dictionary. When
requesting 'human_name', we need to access the 'person' dictionary
first or we throw a KeyError
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkt63FwACgkQeiVVYja6o6MO5wCbBxWmJ7bVn6FxzGuBOta+4IMI
TdYAn20akaNKqn2ibHU2Oy6n17BKOR+Q
=A2UF
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python-fedora-devel-593.patch
Type: text/x-patch
Size: 3906 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20100216/a0dcced4/attachment-0002.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: python-fedora-devel-593.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
Url : http://lists.fedoraproject.org/pipermail/infrastructure/attachments/20100216/a0dcced4/attachment-0003.bin
More information about the infrastructure
mailing list