config-armv7-generic: USB_G_DBGP_PRINTK and USB_G_DBGP_SERIAL

[Josh Boyer]

On Mon, Mar 31, 2014 at 05:59:41PM +0200, Paul Bolle wrote:
> 0) Building an rpm for (vanilla) v3.14, using the origin/f20 branch of
> kernel.git, triggers a warning (a couple of times):
>     .config:5466:warning: override: USB_G_DBGP_SERIAL changes choice state
> 
> 1) It turns out config-armv7-generic contains both
>     CONFIG_USB_G_DBGP_PRINTK=y
> 
> and
>     CONFIG_USB_G_DBGP_SERIAL=y
> 

Adding Peter.  He set both of these as such.

> 2) But in drivers/usb/gadget/Kconfig we see (summarized):
>     choice
>             prompt "EHCI Debug Device mode"
>             default USB_G_DBGP_SERIAL
> 
>     config USB_G_DBGP_PRINTK
>             bool "printk"
> 
>     config USB_G_DBGP_SERIAL
>             bool "serial"
> 
>     endchoice
> 
> If I'm reading this correctly, this means that we need to choose between
> USB_G_DBGP_PRINTK and USB_G_DBGP_PRINTK.

Correct.

> 3) Should we remove one of these two Kconfig macros? Or is the upstream
> Kconfig file incorrect and can both symbols be set simultaneously?

No, looking at dbgp.c it definitely seems to be one or the other.

Peter, do you want that going to printk or serial?

josh