[Bug 209906] Review Request: elektra - A key/value pair database to store software configurations

bugzilla at redhat.com bugzilla at redhat.com
Mon Oct 9 15:55:39 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra -  A key/value pair database to store software configurations


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209906





------- Additional Comments From rc040203 at freenet.de  2006-10-09 11:55 EST -------
(In reply to comment #4)
> (In reply to comment #3)
> 
> > I can avoid re-emphasizing my comments from:
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430#c15
> > 
> > In particular:
> > - header name are too general to all allow them to installed into $(includedir)
> 
> I agree, but I'd prefer to follow upstream, and only if they don't 
> cooperate start changing things.
It's you who is proposing this package, it's you whose task it is to provide
proper integration => It's your job, not upstream.

> > -  Still many warnings, which justify doubts on the package  to be installed
> > into /lib rsp. /bin , /sbin
> 
> There are less warnings, most of them now corresponds with
> error codes not checked, I hope that they are harmless, an audit
> of the code is required to know for sure.
Then please do it - This package wants to be used at boot up, therefore I am
imposing tighter constraints on it than on ordinary applications.

> > In addition to that:
> > - kbd is too general as a program name, c.f.
> > http://docs.sun.com/app/docs/doc/816-0210/6m6nb7mcf?a=view
> 
> It is kdb, not kbd. But I agree that it is too generic anyway, 
> but here too, I'd prefer following upstream.
kdb isn't much better either.

google for kdb.h ...

> > - Please explain in detail why you want to ship static libs. As you probably are
> > aware about, there is a strong tendency to eliminate them.
> 
> I think static libs could be usefull,
I don't.

> in case one want to be sure
> that elektra may still be used within an app even if dynamical 
> linking fails.
If dynamical linking fails almost nothing works on Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the package-review mailing list