[Bug 210025] Review Request: openpbx - The truly open source PBX

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openpbx - The truly open source PBX


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210025


jeff at ocjtech.us changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jeff at ocjtech.us




------- Additional Comments From jeff at ocjtech.us  2006-10-10 13:44 EST -------
Some initial comments... I'll do some more review later...

(In reply to comment #0)
> Spec URL: http://david.woodhou.se/opbx/openpbx.spec
> SRPM URL: http://david.woodhou.se/opbx/openpbx-0-1.svn1912.src.rpm

Should the name of the RPM be "openpbx.org" since that's the formal name? 
Unwieldy, yes, but ISTR that "openpbx" was already taken.

> OpenPBX talks to a variety of telephony hardware including BRI, PRI,
> POTS, Bluetooth headsets and IP telephony clients using SIP and IAX
> protocols protocol (e.g. ekiga or kphone).  For more information and a
> current list of supported hardware, see www.openpbx.com.

Shouldn't the URL be openpbx.org?

> rpmlint complains a lot about non-standard-[ug]id -- obviously I need to add
> the openpbx user to the UserRegistry at
> http://fedoraproject.org/wiki/PackageUserRegistry

Yes, annoying.

> It also complains of lack of documentation for the subpackages, since the
> documentation is in the _main_ package.

I generally add the COPYING to the subpackages unless there are documentation
files that are specific to the subpackage.
 
> It also complaints of mixed-use-of-spaces-and-tabs. I use tabs. Except where
> I need to indent the second and subsequent lines of %config to a column which
> isn't a multiple of 8, where I use some spaces. That's fine.

A completely trivial and pointless check in rpmlint as far as I'm concerned.

> Oh, and log-files-without-logrotate in amongst all the noise. Will fix...



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.