[Bug 229728] Review Request: polyml - Poly/ML compiler and runtime system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: polyml - Poly/ML compiler and runtime system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229728


bos at serpentine.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From bos at serpentine.com  2007-04-18 01:36 EST -------
Here is my review.

MUST:

+ rpmlint looks acceptable.

  W: polyml devel-file-in-non-devel-package /usr/lib64/libpolyml.so
  W: polyml devel-file-in-non-devel-package /usr/lib64/libpolymain.a
  W: polyml-libs no-documentation

+ Meets packaging guidelines.
+ Name of spec file is OK.
+ License is OK (LGPL).
+ License file content matches license.
+ License file is in both source package and %doc.
+ Spec file is in English.
+ Spec file is legible.
+ md5sums match.
+ Builds on x86_64.
+ BuildRequires looks OK.
+ Locales not an issue, since not used.
+ ldconfig is run correctly for -libs package.
+ Not relocatable.
+ Directory ownership OK.
+ No duplicate file names.
+ File permissions look OK.
+ %clean is present.
+ Macro use is consistent.
+ Package contents are permissible.
+ Docs are in -doc package.
+ Docs don't affect runtime.
+ Headers are in -devel package.
+ No libtool turds.
+ No incorrect directory ownership.
+ %install cleans buildroot.
+ File names are UTF-8.

Don't follow MUST guidelines, but acceptable since this is a compiler:

? Static library is not in -static package.
? The symlink %{_libdir}/libpolyml.so in the main package refers to
  libpolyml.so.0.0.0 in the -libs package.

Accordingly, package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.