[Bug 230275] Review Request: varnish - High-performance HTTP accelerator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: varnish - High-performance HTTP accelerator


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=230275





------- Additional Comments From ingvar at linpro.no  2007-04-18 02:23 EST -------
* Kevin Fenzi
> 6. ok on static libs, but did you really want to disable the dynamic
> libs as well? Does anything known link against the varnish dynamic libs?
> Is there a reason to not ship them?

The dynamic libraries are there allright. I just removed the ".so"
symlinks that points to them. These symlinks are usually part of the
-devel package in redhat-based systems, it I have understood
correctly. Varnish itself links to the main-versioned symlink.

$ ls -l /usr/lib64/*varnish*so
lrwxrwxrwx  1 root root 22 feb 28 14:17 /usr/lib64/libvarnishapi.so ->
libvarnishapi.so.0.0.0
lrwxrwxrwx  1 root root 19 feb 28 14:17 /usr/lib64/libvarnish.so ->
libvarnish.so.0.0.0

$ ldd /usr/sbin/varnishd  | grep usr | cut -d '(' -f 1
        libvarnish.so.0 => /usr/lib64/libvarnish.so.0
        libvcl.so.0 => /usr/lib64/libvcl.so.0

So for varnish itself, the .so symlinks are not necessary, though they
might be valuable if anybody want to develop things on top of varnish
later. Thus, they might belong in a future -devel package.

> 7. ok. looks good. You shouldn't need the LICENSE in all the
> subpackages, but it's not a blocker if you want to do so. The
> rpmlint warning about no docs can be ignored for devel subpackages.

I get this warm fuzzy feeling when I get no errors or warnings, you
see. Also note that "all the subpackages" at the moment counts one :-)

> If you really want to ship the INSTALL thats fine I would think.

Good

> So the only final question I see here is if the devel package should
> be shipped or not. 

Well, I don't know of anyone using varnish technology for anything but
varnish, so for an initial release, I'd say it's not necessary. A
devel package should perhaps include some header files and some
hacking starting point docs too. If we can push it for later, I'll ask
some of the developers for this.

Ingvar


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.