[Bug 250971] Review Request: ivtv - An iTVC15/16 and CX23415/16 driver

bugzilla at redhat.com bugzilla at redhat.com
Sun Aug 26 19:11:59 UTC 2007


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ivtv - An iTVC15/16 and CX23415/16 driver


https://bugzilla.redhat.com/show_bug.cgi?id=250971





------- Additional Comments From nicolas.mailhot at laposte.net  2007-08-26 15:11 EST -------
Some other comments

1. upstream released a new version, please update

2. now perl is not in the buildroots, a sed buildrequires would be lighter for
munging

3. should probably require the firmware stuff

4. the mpg stuff should be dumped since it's part of firmware

5. kill the kernel header

6. personnaly, I prefer explicit defattr that set permissions and install -d
instead of mkdir

7. I'd classify ivtv in System Environment/Kernel as those are low-level tools
closely associated to the kernel

8. I'd also build and install the tools in test, in a separate package if necessary

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.




More information about the package-review mailing list