[Bug 223633] Review Request: csync2 - A cluster synchronization tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: csync2 - A cluster synchronization tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223633





------- Additional Comments From ruben at rubenkerkhof.com  2007-01-24 07:03 EST -------
Thanks for the review Manuel.
My comments inline:

>> As a sidenote, you could have used a 1 line sed command in %install in
>> order to modify the offending line in xinetd.conf, rather then creating a
>> separate patch, but your method is perfectly fine.

I actually changed 2 lines in csync2.xinetd ;-) I prefer clean patches to 
regular expressions in spec files. That way, if something changes in the 
source, the patch fails to apply and I can fix it.

>> In order to start the program (via xinetd), /etc/services must be modified,
>> adding a line specifying the port and protocol used by csync2 and SSL
>> certificates must be generated for each box where the program will run

There's no need to edit /etc/services, since xinetd doesn't require it.
I tried creating the ssl certificates in %install (make cert does this), but 
in mock, openssl seems to have problems opening a random device. I'm not sure 
what's the best way to handle this. Maybe just ship a self-signed cert with 
the rpm?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.