[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-23 10:57 EST -------
For 0.1.0-1:

* License
  - While COPYING says this is licensed under LGPL (and you
    tagged this rpm as such, although COPYING is missing on
    %doc entry), common.c, instrum.c, etc... are licensed 
    under _GPL_ .

? Dependency
  - Would you explain why main package should explicitly have
    "Requires: timidity++"?

? binary executable files
  - Are test/.libs/{playmidi,midi2raw} of no use?
    (playmidi seems to be created only with have libao-devel
     installed).

* libtimidity.pc
  - Why does this need "-lm" on Libs? Linkage against libm.so
    is already done on libtimidity.so and extra linkage like
    this must be removed unless header files installed require
    it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.