[Bug 248119] Review Request: libtimidity - MIDI to WAVE converter library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libtimidity - MIDI to WAVE converter library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248119





------- Additional Comments From j.w.r.degoede at hhs.nl  2007-07-23 11:18 EST -------
(In reply to comment #1)
> For 0.1.0-1:
> 
> * License
>   - While COPYING says this is licensed under LGPL (and you
>     tagged this rpm as such, although COPYING is missing on
>     %doc entry), common.c, instrum.c, etc... are licensed 
>     under _GPL_ .
> 

These files come from timidity (through SDL_mixer, which also is LGPL), when
timidity was discontinued it was set free under a choice if GPL / LGPL /
artistic, see:
http://web.archive.org/web/20010106150700/http://www.cgs.fi/~tt/discontinued.html

Also see the first paragraph of the included COPYING which says:

Please note that the included source from TiMidity, is also licensed
 under the following terms (GNU LGPL), but can also be used separately
 under the GNU GPL, or the Perl Artistic License. Those licensing
 terms are not reprinted here, but can be found on the web easily.

I will include the missing COPYING file, good catch.

> ? Dependency
>   - Would you explain why main package should explicitly have
>     "Requires: timidity++"?
> 

Because timidity++ provides the necessary patch files containing the wavetable
instruments, this is why for example SDL_mixer and allegro also require timidity++.

> ? binary executable files
>   - Are test/.libs/{playmidi,midi2raw} of no use?
>     (playmidi seems to be created only with have libao-devel
>      installed).
> 

There already is a cmdline utility called playmidi (or atleast was), also we
already have playmus from SDL_mixer and timidity itself through timidity++,
notice that the standalone version of timidity is of much better quality (and
much more cpu intensive). So I see little use in these test apps, if people want
to play or convert midi using timidity they should be using the standalone version.


> * libtimidity.pc
>   - Why does this need "-lm" on Libs? Linkage against libm.so
>     is already done on libtimidity.so and extra linkage like
>     this must be removed unless header files installed require
>     it.

Many package config files contain libs in the LDFLAGS against which the lib
itself is already linked, this is normal behaviour as not all Unix OS's support
.so files having deps, so sometimes the app itself must be linked against the
deps, so that the symbols will be there for the lib.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.