[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ustr - String library, very low memory overhead, simple to import


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-07-25 14:35 EST -------
Created an attachment (id=159970)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=159970&action=view)
mock build log of ustr 1.0.0-2

Well, actually a lot of rpmlint complaints...

-----------------------------------------------------
W: ustr incoherent-version-in-changelog 1.0.0-1 1.0.0-2.fc8
W: ustr invalid-license MIT, LGPL, BSD
W: ustr unstripped-binary-or-object /usr/lib/libustr-1.0.so.1.0.0
W: ustr invalid-license MIT, LGPL, BSD
W: ustr strange-permission ustr.spec 0600
W: ustr-debug no-documentation
E: ustr-debug library-without-ldconfig-postin
/usr/lib/libustr-debug-1.0.so.1.0.0
E: ustr-debug library-without-ldconfig-postun
/usr/lib/libustr-debug-1.0.so.1.0.0
W: ustr-debug no-dependency-on ustr
W: ustr-debug summary-ended-with-dot String library, very very low memory
overhead, simple to import.
W: ustr-debug invalid-license MIT, LGPL, BSD
W: ustr-debug unstripped-binary-or-object /usr/lib/libustr-debug-1.0.so.1.0.0
W: ustr-debug-static no-documentation
W: ustr-debug-static summary-ended-with-dot String library, very very low
memory overhead, simple to import.
W: ustr-debug-static invalid-license MIT, LGPL, BSD
E: ustr-debuginfo empty-debuginfo-package
W: ustr-debuginfo invalid-license MIT, LGPL, BSD
W: ustr-devel hidden-file-or-dir /usr/share/ustr-1.0.0/.gdbinit
W: ustr-devel summary-ended-with-dot String library, very very low memory
overhead, simple to import.
W: ustr-devel invalid-license MIT, LGPL, BSD
W: ustr-static no-documentation
W: ustr-static summary-ended-with-dot String library, very very low memory
overhead, simple to import.
W: ustr-static invalid-license MIT, LGPL, BSD
------------------------------------------------------
Summary
* version mismatch between the last entry of %changelog and
  rpm EVR.
* Perhaps MIT/LGPL/BSD will remove rpmlint complaint.
* Please change the permission of spec/tarball to 0644
* Calling ldconfig is needed for library
* "unstripped-binary-or-object" is usually due to wrong
  permission (i.e. this binary should have executable permission,
  usually 0755)
* Please remove dot from the end of summary
* debuginfo rpm is empty. This means that debug option "-g" flag
  is not used on compile.
  I checked the build log (attached) but no useful information is
  gained from the build log.
  - Please make the build log more verbose
  - and Fedora specific compilation flags are perhaps not honored.
* What is the file /usr/share/ustr-1.0.0/.gdbinit for?

Other quick comment:
* Source must be written with full URL.
* Please check directories' ownership.
* Usually the dependency for main or subpackage should be
  version-release number specific
* summary seems all the same for all packages??
* Please use %_includedir
* Files under %_datadir/doc or %_mandir are automatically
  tagged as %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.