[Bug 248231] Review Request: ustr - String library, very low memory overhead, simple to import

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ustr - String library, very low memory overhead, simple to import


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248231





------- Additional Comments From james.antill at redhat.com  2007-07-25 14:56 EST -------
* version mismatch between the last entry of %changelog and
  rpm EVR.

 Fair enough.

* Perhaps MIT/LGPL/BSD will remove rpmlint complaint.

 I'll try that.

* Please change the permission of spec/tarball to 0644

 This will happen automatically when it goes into Fedora CVS, no? Doing this
outside of Fedora CVS means playing with my umask settings.

* Calling ldconfig is needed for library

 AIUI this isn't required. You either need to call ldconfig, or explicitly
generate the symlinks that ldconfig would do ... but not both. And the former is
preferred. If you could point to something official that says otherwise, I'll
gladly change it.

* "unstripped-binary-or-object" is usually due to wrong
  permission (i.e. this binary should have executable permission,
  usually 0755)

 Fixed.

* Please remove dot from the end of summary

 Yeh, I thought I'd done that but I only did the main package.

* debuginfo rpm is empty. This means that debug option "-g" flag
  is not used on compile.
  I checked the build log (attached) but no useful information is
  gained from the build log.
  - Please make the build log more verbose
  - and Fedora specific compilation flags are perhaps not honored.

 I'll look into this, it doesn't use autoconf ... so I might well need to pass
something for CFLAGS.

* What is the file /usr/share/ustr-1.0.0/.gdbinit for?

 It can be copied to a users (developer using the library) home dir, and is
copied via. the ustr-import to the working directory.
 I can change the library to call it gdbinit.txt, if I really need to ... it
just seems like a false warning (and as with all lints there's no good way to
turn it off).

Other quick comment:
* Source must be written with full URL.

 Fixed.

* Please check directories' ownership.

 Which directories?

* Usually the dependency for main or subpackage should be
  version-release number specific

 As far as I can see they all do. Which one isn't?

* summary seems all the same for all packages??

 This is common for libraries, no? For instance glib2 and glib2-devel have the
same summary but different descriptions ... what else should I be doing?

* Please use %_includedir

 Fixed.

* Files under %_datadir/doc or %_mandir are automatically
  tagged as %doc

 Ok, removed the doc tag.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.