[Bug 226218] Merge Review: openssh

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: openssh


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226218


mastahnke at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mastahnke at gmail.com
               Flag|                            |fedora-review?




------- Additional Comments From mastahnke at gmail.com  2007-03-04 00:15 EST -------
According to http://fedoraproject.org/wiki/Packaging/SourceURL , it looks like
we need just a tiny bit more detail on howto generate the source file used for
this package form upstream.  I assume that you just download upstream's version
and run  openssh-nukeacss.sh, is there anything more to it than that?  Even if
that is all, please place that comment in the spec. 

I am trying to find the right way to approcah the /etc/profile.d/ files.  They
are quite similar to init scripts in that many people think they shouldn't be
edited, if so, they don't have to be %config.  If they are %config they should
probably be noreplace to preserve edits. 

Also, if they are only sourced and not executed, could they be 644 permissions
rather than 755?

[builder at rawhide i386]$ rpmlint openssh-askpass-4.5p1-4.i386.rpm
W: openssh-askpass conffile-without-noreplace-flag
/etc/profile.d/gnome-ssh-askpass.csh
W: openssh-askpass conffile-without-noreplace-flag
/etc/profile.d/gnome-ssh-askpass.sh
W: openssh-askpass no-documentation
E: openssh-askpass executable-marked-as-config-file
/etc/profile.d/gnome-ssh-askpass.sh
E: openssh-askpass executable-sourced-script /etc/profile.d/gnome-ssh-askpass.sh
0755
E: openssh-askpass executable-marked-as-config-file
/etc/profile.d/gnome-ssh-askpass.csh
E: openssh-askpass executable-sourced-script
/etc/profile.d/gnome-ssh-askpass.csh 0755
[builder at rawhide i386]$                                                        
          

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.