[Bug 228960] Review Request: java-1.5.0-gcj - JPackage compatibility layer for GCJ
bugzilla at redhat.com
bugzilla at redhat.com
Thu Mar 8 17:17:18 UTC 2007
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: java-1.5.0-gcj - JPackage compatibility layer for GCJ
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=228960
------- Additional Comments From overholt at redhat.com 2007-03-08 12:17 EST -------
A few more comments:
. can you explain the need for the triggerins? Is it just in case a
newer set of gcc RPMs is installed and we need to have
explicitly-versioned symlinks?
. in %files javadoc, you have a comment that says that
%{_javadocdir}/java will conflict with other packages owning it - is
there no alternative entry for that directory? Should there be?
* no static libs
* no rpath
* config files should marked with %config(noreplace)
* not a GUI app
* sub-packages fine (-devel, -src, etc.)
* macros used appropriately and consistently
- ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
* %makeinstall not used
* no locale data
* Requires(pre,post) fine
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* file permissions okay; %defattrs present
* %clean present
* %doc files do not affect runtime
* not a webapp
? verify the final provides and requires of the binary RPMs
Once we fix the GIJ_VERSION at the top of the specfile, I think the requires
will be okay (ie. the >= 4.0.0 will become the correct version). Do you think
we should explicitly require the version and not have a >= for it?
$ rpm -qp --requires
/home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-1.5.0.0-1.i386.rpm
/bin/bash
/bin/sh
/bin/sh
/bin/sh
/usr/bin/gcj-dbtool
/usr/bin/gcj-dbtool
/usr/bin/gij
/usr/bin/gij
/usr/bin/rebuild-gcj-db
/usr/bin/rebuild-gcj-db
/usr/bin/rebuild-security-providers
/usr/bin/rebuild-security-providers
/usr/sbin/alternatives
/usr/sbin/alternatives
config(java-1.5.0-gcj) = 1.5.0.0-1
jpackage-utils >= 1.7.3
libgcj >= 4.0.0
mx4j >= 3.0.1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
$ rpm -qp --requires
/home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-devel-1.5.0.0-1.i386.rpm
/bin/sh
/bin/sh
/bin/sh
/bin/sh
/usr/bin/env
/usr/bin/gcj
/usr/sbin/alternatives
/usr/sbin/alternatives
eclipse-ecj >= 3.2.1
gcc-java >= 4.0.0
java-1.5.0-gcj = 1.5.0.0-1
java_cup >= 0.10
python >= 2.5
python(abi) = 2.5
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
$ rpm -qp --requires
/home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-src-1.5.0.0-1.i386.rpm
java-1.5.0-gcj = 1.5.0.0-1
libgcj-src >= 4.0.0
/usr/bin/gij
rpmlib(VersionedDependencies) <= 3.0.3-1
/bin/sh
/bin/sh
/bin/sh
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
$ rpm -qp --requires
/home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-javadoc-1.5.0.0-1.i386.rpm
java-1.5.0-gcj = 1.5.0.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
* run rpmlint on the binary RPMs
$ rpmlint /home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-1.5.0.0-1.i386.rpm
E: java-1.5.0-gcj only-non-binary-in-usr-lib
W: java-1.5.0-gcj dangling-relative-symlink
/usr/share/java/gcj-endorsed/mx4j-remote.jar ../mx4j/mx4j-remote.jar
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre/bin/rmiregistry
../../../../../bin/grmiregistry
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/security/java.security
../../../../../security/classpath.security
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm-exports/java-1.5.0-gcj-1.5.0.0/jaas-1.5.0.0.jar
../../jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/jaas.jar
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm-exports/java-1.5.0-gcj-1.5.0.0/jdbc-stdext-1.5.0.0.jar
../../jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/jdbc-stdext.jar
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm-exports/java-1.5.0-gcj-1.5.0.0/jsse-1.5.0.0.jar
../../jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/jsse.jar
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/jre/bin/keytool ../../../../../bin/gkeytool
W: java-1.5.0-gcj dangling-relative-symlink
/usr/lib/jvm-exports/java-1.5.0-gcj-1.5.0.0/jndi-1.5.0.0.jar
../../jvm/java-1.5.0-gcj-1.5.0.0/jre/lib/jndi.jar
W: java-1.5.0-gcj dangling-relative-symlink
/usr/share/java/gcj-endorsed/mx4j.jar ../mx4j/mx4j.jar
W: java-1.5.0-gcj dangerous-command-in-%post ln
W: java-1.5.0-gcj dangerous-command-in-%trigger ln
$ rpmlint /home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-devel-1.5.0.0-1.i386.rpm
E: java-1.5.0-gcj-devel only-non-binary-in-usr-lib
W: java-1.5.0-gcj-devel no-documentation
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/jarsigner ../../../../bin/gjarsigner
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/java ../../../../bin/gij
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/jar ../../../../bin/fastjar
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/rmic ../../../../bin/grmic
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/rmiregistry ../../../../bin/grmiregistry
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/keytool ../../../../bin/gkeytool
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/javac ../../../../bin/ecj
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/javah ../../../../bin/gjavah
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm/java-1.5.0-gcj-1.5.0.0/bin/appletviewer ../../../../bin/gappletviewer
W: java-1.5.0-gcj-devel dangling-relative-symlink
/usr/lib/jvm-exports/java-1.5.0-gcj java-1.5.0-gcj-1.5.0.0
W: java-1.5.0-gcj-devel dangerous-command-in-%post ln
W: java-1.5.0-gcj-devel dangerous-command-in-%trigger ln
$ rpmlint /home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-javadoc-1.5.0.0-1.i386.rpm
$ rpmlint /home/andrew/rpmbuild/RPMS/i386/java-1.5.0-gcj-src-1.5.0.0-1.i386.rpm
W: java-1.5.0-gcj-src no-documentation
W: java-1.5.0-gcj-src dangerous-command-in-%post ln
W: java-1.5.0-gcj-src dangerous-command-in-%postun rm
W: java-1.5.0-gcj-src dangerous-command-in-%trigger ln
SHOULD:
* package should include license text in the package and mark it with %doc
* package should build on i386
? package should build in mock
I haven't tried
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the package-review
mailing list