[Bug 225400] Review Request: tetrinetx - The GNU TetriNET server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tetrinetx - The GNU TetriNET server


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225400





------- Additional Comments From jpmahowald at gmail.com  2007-03-13 03:37 EST -------
I had built it in mock. However rpmbuild also leaves an empty game.conf in
~/rpmbuild/BUILD/tetrinetx-1.13.16+qirc-1.40c/bin    It exists in the source
tarball. It seems that your cat/sed command in the spec is screwing it up. Use
sed's (well, GNU sed's --in-place option instead.


In the build log I get:
warning: File listed twice: /etc/tetrinetx/game.conf
warning: File listed twice: /etc/tetrinetx/game.motd
warning: File listed twice: /etc/tetrinetx/game.pmotd
warning: File listed twice: /etc/tetrinetx/game.secure

Which is a result of listing it twice. Use the %dir directive if you only want
the directory. http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html

Speaking of config files, do note that the config_dir patch hardcodes the
location. There at least needs to be a comment in the spec, if someone moved
%{_sysconfdir} they would want to know why it didn't go with.

As much as I also like searching on tetris, I want to avoid the trademark. You
can get a second opinion on this, but I'd rather not use that term.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.