[Bug 221084] Review Request: dkms - Dynamic Kernel Module Support

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dkms - Dynamic Kernel Module Support


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221084





------- Additional Comments From mebrown at michaels-house.net  2007-03-19 12:12 EST -------
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
MUST ITEMS:
* rpmlint results above
* meets naming guidelines
* spec file name maches %{name}.spec
* meets Packaging guidelines with one exception
* open source license
* license matches actual license
* text of license included in %doc
* spec in american english
* spec legible
* source matches upstream
* package builds on all arches
* no build deps
* no shared libs
* no Prefix: (not relocatable)
* owns its dirs
* do duplicate %files
* includes %defattr, most %files entries properly set perms.
* clean section removes buildroot
* consistent use of macros
* contains code
* no large docs, no -doc subpackage
* files in %doc are not used in runtime
* no headers
* no libs (static or dynamic)
* is not a -devel package
* no libtool archives
* no GUI app, no .desktop files
* doesnt own files/dirs used by other packages

SHOULD ITEMS:
* upstream includes license text
* builds in mock
* compiles on supported arches
* functions as described
* scriptlets sane
* no -devel
* no pkgconfig files
* no deps outside std system dirs.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.