[Bug 238824] Review Request: schismtracker - sound module composer/player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schismtracker - sound module composer/player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238824


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |ville.skytta at iki.fi
               Flag|                            |fedora-review?




------- Additional Comments From ville.skytta at iki.fi  2007-05-03 11:41 EST -------
- MIME type associations missing from .desktop file, suggested:
    MimeType=audio/x-mod;audio/x-s3m;audio/x-stm;audio/x-it;audio/x-xm;
  Remember update-desktop-database too, see Packaging/ScriptletSnippets in Wiki

- Menu entry icon missing - install a bunch of different sizes from icons/
subdirs to /usr/share/icons/hicolor/*?

- What are the libXau-devel and libXdmcp-devel build dependencies used for?

- Missing build dependencies: libXt-devel, libXxf86misc-devel, libXv-devel

- %configure --disable-dependency-tracking for cleaner build output and possibly
a slight build speedup?

- Separate creation of the applications dir shouldn't be needed, I think
desktop-file-install takes care of it.

- Shouldn't COPYING.frag-opt and COPYING.libmodplug be included in %doc?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.