[Bug 238824] Review Request: schismtracker - sound module composer/player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: schismtracker - sound module composer/player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238824


jnovy at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?(ville.skytta at iki.f
                   |                            |i)




------- Additional Comments From jnovy at redhat.com  2007-05-03 15:14 EST -------
First, thanks for the review.


(In reply to comment #1)
> - MIME type associations missing from .desktop file, suggested:
>     MimeType=audio/x-mod;audio/x-s3m;audio/x-stm;audio/x-it;audio/x-xm;

Ok, I also added the audio/x-669-mod and audio/x-mtm.

>   Remember update-desktop-database too, see Packaging/ScriptletSnippets in Wiki

Done.

> - Menu entry icon missing - install a bunch of different sizes from icons/
> subdirs to /usr/share/icons/hicolor/*?
> 

Done.

> - What are the libXau-devel and libXdmcp-devel build dependencies used for?

ldd says schismtracker is dependent on them, so I listed them explicitely.

> - Missing build dependencies: libXt-devel, libXxf86misc-devel, libXv-devel

These seem to be brought by SDL-devel.

> - %configure --disable-dependency-tracking for cleaner build output and possibly
> a slight build speedup?

Done.

> - Separate creation of the applications dir shouldn't be needed, I think
> desktop-file-install takes care of it.

the useless install is now removed.

> - Shouldn't COPYING.frag-opt and COPYING.libmodplug be included in %doc?

Added.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.