[Bug 253549] Review Request: TzClock - GTK+ Time Zone Clock

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: TzClock - GTK+ Time Zone Clock


https://bugzilla.redhat.com/show_bug.cgi?id=253549





------- Additional Comments From chris at theknight.co.uk  2007-09-05 09:59 EST -------
(In reply to comment #1)
> A few comment:
> - How about a desktop file?
> - Would be nice to use %configure and %{_bindir}.
> - changelog entry would be nice too
> - you should not use the Packager field in fedora packages: your name will be in
> the changelog
> - url to source tarball should be used
> - I would replace "X" by "Cairo" say in the Summary.
> 
> You probably want to run rpmlint on the srpm and rpm to check for more things.
> 
> Very cool clock! :-)

Thank you for your comments, I am still learning about building rpms so all help
is welcome.  I have updated the spec file, and uploaded a new version.

I am interested in your question about a desktop file.  Where can I find out
more about these?

Thanks again, Chris.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.