[Bug 458359] Review Request: gpscorrelate - A GPS photo correlation / geotagging tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458359





--- Comment #4 from Till Maas <opensource at till.name>  2008-08-14 06:25:11 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Uh, thanks. I meant to add it before I submitted the review. Here it is:
> 
> I recommend not use a vendor in desktop-file-install.

The current guidelines still demand a vendor, but I agree that it seems to be
better to not use it.

> You really must provide an icon:
> https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
> 
> And therefore you need to add hicolor-icon-theme to Requires.

I do not see there, that I have to provide an icon, there is only described how
the icon should be specified in the desktop file. The Desktop Entry
Specification that is linked there also says, that an icon is not required.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.