[Bug 458359] Review Request: gpscorrelate - A GPS photo correlation / geotagging tool

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 14 12:56:09 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458359





--- Comment #5 from Andrea Musuruane <musuruan at gmail.com>  2008-08-14 08:56:08 EDT ---
(In reply to comment #4)
> The current guidelines still demand a vendor, but I agree that it seems to be
> better to not use it.

Guidelines say that using this form is acceptable:
desktop-file-install --vendor="" \
[...]

As you noted it is a suggestion :)

> I do not see there, that I have to provide an icon, there is only described how
> the icon should be specified in the desktop file. The Desktop Entry
> Specification that is linked there also says, that an icon is not required.

I think that this will be the first GUI package in Fedora not to use an icon...
not a nice thing to see. You can ask to the Art Team for one.

I just noticed that you missed the use of the %{name} macro here:
Source0:        http://freefoote.dview.net/linux/gpscorrelate-%{version}.tar.gz

The Debian package has a man page. You might want to include it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list