[Bug 455380] Review Request: tqsllib - The TrustedQSL library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455380


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu




--- Comment #5 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-21 12:38:12 EDT ---
Thanks.  For some reason I thought I had run through my checklist already, but
I hadn't.  It usually helps to uncover some additional issues:

I note that the compiler flags are a litle weird; the makefile supplies "-g3 -O
-Wall" and then the spec provides the usual Fedora set.  I've verified that gcc
will use the ones specified later on the command line, so there's no real
problem but you might consider patching the extra ones out.

This package should own /usr/share/tqsl, I think.

Since that's the only real issue, I'll go ahead and approve this and you can
fix it when you check in.

* source files match upstream:
   083c4405455c5b5a711e82275fe2b7106266bfc1edbd1a78ef542244e25909dc  
   tqsllib-2.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
  tqsllib-2.0-3.fc10.x86_64.rpm
   libtqsllib.so.1()(64bit)
   tqsllib = 2.0-3.fc10
   tqsllib(x86-64) = 2.0-3.fc10
  =
   /sbin/ldconfig
   libcrypto.so.7()(64bit)
   libexpat.so.1()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libstdc++.so.6(GLIBCXX_3.4.9)(64bit)
   libtqsllib.so.1()(64bit)
   libz.so.1()(64bit)

  tqsllib-devel-2.0-3.fc10.x86_64.rpm
   tqsllib-devel = 2.0-3.fc10
   tqsllib-devel(x86-64) = 2.0-3.fc10
  =
   libtqsllib.so.1()(64bit)
   tqsllib = 2.0-3.fc10

* %check is not present; no test suite included.  I have no idea how to test 
   this software.
* a shared library is installed:
   ldconfig called properly.
   unversioned .so link is in the -devel package.
X fails to own /usr/share/tqsl.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (ldconfig).
* code, not content.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.