[Bug 455067] Review Request: ferm - For Easy Rule Making

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455067


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-21 13:02:01 EDT ---
As it seems that the current latest version is 1.3.5, would you update srpm
first?

Some notes:
- The name of spec file must be "ferm.spec"
- "ferm -" is redundant for Summary.
- "system/firewalls" is not a standard Group (please refer to
  $ rpmlint -I non-standard-group
- Please remove some meaningless release number suffix.
- The license tag "GPL" is not allowed on current Fedora packaging guidelines:
  https://fedoraproject.org/wiki/Packaging/LicensingGuidelines
  https://fedoraproject.org/wiki/Licensing
- Source must be given by full URL:
  https://fedoraproject.org/wiki/Packaging/SourceURL
- "Requires: perl" is redundant. Usually perl (module) related dependencies are
  automatically detected and added to rebuilt binary rpms by rpmbuild.
- Move the lines:
-----------------------------------------------------------------
sed -i 's/PREFIX = /#PREFIX = /' config.mk
sed -i 's/MANDIR = /#MANDIR = /' config.mk
sed -i 's/DOCDIR = /#DOCDIR = /' config.mk
-----------------------------------------------------------------
  to %build or %prep (%prep is preferred for --short-circuit option)
- Please use macros. /usr should be %{_prefix}, for example:
  https://fedoraproject.org/wiki/Packaging/RPMMacros
- Now %defattr(-,root,root,-) is preferred.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.