[Bug 435829] Review Request: tomcat6 - Apache Servlet/JSP Engine, RI for Servlet 2.5/JSP 2.1 API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tomcat6 -  Apache Servlet/JSP Engine, RI for Servlet 2.5/JSP 2.1 API


https://bugzilla.redhat.com/show_bug.cgi?id=435829





------- Additional Comments From dwalluck at redhat.com  2008-03-18 11:40 EST -------
* packages meets FHS (http://www.pathname.com/fhs/)

I changed from /srv in the upstream JPackage spec as I don't think Fedora allows
this, but I can't find any reference right now.

X specfile is legible
 - in tomcat6-6.0.conf, JAVA_HOME is set to /usr/lib/jvm/java-icedtea, shouldn't
it be set to /usr/lib/jvm/java and set alternatives to set icedtea to be the jvm?

I think I should get rid of the specific icedtea reference. But fnasser
mentioned it had to be built and run on icedtea. However, I don't think we
should exclude GCJ, but it hasn't be tested by me on there.

X BuildRequires are proper

Will build again in mock.

X sed doesn't need to be listed as a BR.

OK

X package should build in mock

Package built in mock for me when I posted it. This is due to the recent change
to java-1.6.0-openjdk. Removing the specific requirement on icedtea will fix this.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.