[Bug 448606] Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD


https://bugzilla.redhat.com/show_bug.cgi?id=448606





------- Additional Comments From martin.sourada at gmail.com  2008-05-27 17:21 EST -------
(In reply to comment #1)
> Couple of quick notes:
> 1. Your gtk icon cache scriptlets don't follow the guidelines.  Refer to:
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache
Aah, didn't noticed there was such a guideline (it wasn't around about a year
ago or so, was it?). Fixed.

> 2. Looks like the configure file requires a run time gstreamer plugin to build.
>  Refer to: http://koji.fedoraproject.org/koji/getfile?taskID=631159&name=build.log
Yup, it needs gstreamer-plugins-good. I overlooked it bacause it needs only the
runtime package...

SPEC: http://mso.fedorapeople.org/packages/SPECS/subtitleeditor.spec
SRPM: http://mso.fedorapeople.org/packages/SRPMS/subtitleeditor-0.21.1-2.fc9.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.