[Bug 448606] Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: subtitleeditor - GTK+2 tool to edit subtitles for GNU/Linux/*BSD


https://bugzilla.redhat.com/show_bug.cgi?id=448606


bdpepple at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |bdpepple at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+




------- Additional Comments From bdpepple at gmail.com  2008-05-27 21:48 EST -------
MD5Sum:
1cd4433c3ccdbc770fa4c91b1e95697a  subtitleeditor-0.21.1.tar.gz

Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Valid license tag
* Buildroot has all required elements
* All paths begin with macros
* All necessary BuildRequires listed.
* Make succeeds even when %{_smp_mflags} is defined
* Files have appropriate permissions and owners
* Rpmlint does not find problems
* Package installs and uninstalls cleanly

Minor (non-blocker):
* Might want to consider building w/ unit testing.

+1 APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.