[Bug 466777] Review Request: perl-Satcon - Framework for configuration files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466777





--- Comment #4 from Miroslav Suchy <msuchy at redhat.com>  2008-10-23 04:54:39 EDT ---

>Is 1.6 an actual release?  Because that doesn't seem to make sense when the
>only way to get it is to check it out of git.

Yeah, perl-Satcon-1.6-1 is last release. See
http://miroslav.suchy.cz/spacewalk/gitstat/tag.php for list of recent tags.

>You need to provide instructions for actually checking the packaged version out
>of git, not just what's currently at the head of the tree.

I did. See this comment inside spec:
# This src.rpm is cannonical upstream
# You can obtain it using this set of commands
# git clone git://git.fedorahosted.org/git/spacewalk.git/
# cd projects/perl-Satcon
# make srpm
The provided Makefile will checkout the git to the tag perl-Satcon-1.6-1
(commits after this tag are ignored) and make srpm from that version.

> I know you probably depend on the names now, but is there really any point in
> postfixing the executable names with ".pl"?
You know... I did not write that code. I just take the code as is and try to
include it in Fedora. The code is several years old. And yeah, several thing we
are doing different today. But it works, and I'm trying to as little as
possible, during review. 

> I note this package provides perl(Satcon) = 1.3, which is... odd.  The module
> version differs from the package version?
Yeah there was hardcoded version in module. I removed it:

Updated SPEC:
http://miroslav.suchy.cz/fedora/perl-Satcon/perl-Satcon.spec
Updated SRPM:
http://miroslav.suchy.cz/fedora/perl-Satcon/perl-Satcon-1.7-1.f10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.