[Bug 495001] Review Request: bareftp - File transfer client supporting the FTP, FTP over SSL/TLS (FTPS) and SSH File Transfer Protocol (SFTP)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495001





--- Comment #7 from Simon Wesp <cassmodiah at fedoraproject.org>  2009-04-14 16:32:02 EDT ---
--- Licensing:

<spot> cassmodiah: okay, so the code from SharpSSH and JSch is BSD, the Banshee
bits are MIT, the Classpath bits are GPLv2+ with exceptions
<spot> cassmodiah: if you combine all of that with GPLv2 only code, you end up
with GPLv2 with exceptions
<spot> cassmodiah: feel free to put that in comments above the License tag to
explain it. :)

--- hicolor
> Nope, hicolor-icon-theme doesn't need to be specified explicitly, because we
> already have a valid dependency chain: bareftp -> gtk-sharp2 -> gtk ->
> hicolor-icon-theme
my fault!

--- macros
>> please use name macro instead of name
> No need to use macros everywhere, just where it makes sense.
i think it's look more beautiful and i thought it was also meant with
MUST: Each package must consistently use macros.
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines

--- BuildRequires:  perl(XML::Parser)
you are absolutely right


--- rpmlint
bareftp.i386: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

bareftp.i386: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

bareftp-debuginfo.i386: E: empty-debuginfo-package
This debuginfo package contains no files.  This is often a sign of binaries
being unexpectedly stripped too early during the build, rpmbuild not being
able to strip the binaries, the package actually being a noarch one but
erratically packaged as arch dependent, or something else.  Verify what the
case is, and if there's no way to produce useful debuginfo out of it, disable
creation of the debuginfo package.

3 packages and 0 specfiles checked; 2 errors, 1 warnings.

you can't fix no-binary, this is okay

you can fix only-non-binary-in-usr-lib if you move it to datadir, but this
won't make sense (imho) 

you can't create an debug package on normal way
https://bugzilla.redhat.com/show_bug.cgi?id=430500
https://fedoraproject.org/wiki/Packaging/Debuginfo
add a debug nil


@Itamar
i read my comment3 again. sounds 1) very rude 2) not very helpfully. No offense
meant, I'm really sorry

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.