[Bug 495001] Review Request: bareftp - File transfer client supporting the FTP, FTP over SSL/TLS (FTPS) and SSH File Transfer Protocol (SFTP)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495001





--- Comment #8 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-14 17:51:01 EDT ---
(In reply to comment #7)
> > Nope, hicolor-icon-theme doesn't need to be specified explicitly, because we
> > already have a valid dependency chain: bareftp -> gtk-sharp2 -> gtk ->
> > hicolor-icon-theme
> my fault!

No problem, it's not really an error but just a note. Requiring
hicolor-icon-theme wont do no harm.

> --- macros
> >> please use name macro instead of name
> > No need to use macros everywhere, just where it makes sense.
> i think it's look more beautiful and i thought it was also meant with
> MUST: Each package must consistently use macros.
> https://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Consistently means not to mix different macro styles (e.g. $RPM_BUILD_ROOT and
%{buildroot}. The only must are dir names like %{_datadir} instead of
/usr/share, the rest is up to the packager. For more info see 
https://fedoraproject.org/wiki/Packaging/Guidelines#macros

> bareftp.i386: E: no-binary
> The package should be of the noarch architecture because it doesn't contain
> any binaries.
> 
> bareftp.i386: W: only-non-binary-in-usr-lib
> There are only non binary files in /usr/lib so they should be in /usr/share.

These are false positives, rpmlint does not seem to be familiar with mono - but
I am nether.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.