[Bug 495693] Review Request: perl-Syntax-Highlight-Perl6 - Perl 6 Syntax Highlighter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495693


Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Iain Arnell <iarnell at gmail.com>  2009-04-14 23:33:16 EDT ---
+ source files match upstream.  
  ac5652afbe2a89cb5df86cb069c2e6500cfb490e  Syntax-Highlight-Perl6-0.040.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
- license field could be complicated
  This library also includes the following libraries:
  STD.pm by Larry Wall (Artistic License 2.0)
  JQuery by John Resig (dual licensed under the MIT and GPL licenses).

  more like (GPL+ or Artistic) and Artistic 2.0 and (MIT or GPLv2) ?

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  https://koji.fedoraproject.org/koji/taskinfo?taskID=1297595

- package installs properly.
  Error: Missing Dependency: perl(STD) is needed by package
perl-Syntax-Highlight-Perl6-0.040-1.fc11.noarch
(perl-Syntax-Highlight-Perl6-0.040-1.fc11.noarch.rpm)

- rpmlint has complaints:
  perl-Syntax-Highlight-Perl6.noarch: I: checking
  perl-Syntax-Highlight-Perl6.noarch: E: non-executable-script
/usr/lib/perl5/vendor_perl/5.10.0/Cursor.pmc 0644
  perl-Syntax-Highlight-Perl6.src: I: checking
  perl-Syntax-Highlight-Perl6.src: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 9)
  2 packages and 0 specfiles checked; 1 errors, 1 warnings.


- final provides are missing (Cursor) and (STD)
  perl(LazyMap)  
  perl(Syntax::Highlight::Perl6) = 0.040
  perl(Syntax::Highlight::Perl6::Actions)  
  perl-Syntax-Highlight-Perl6 = 0.040-1.fc11

+ final requires are sane:
  /usr/bin/perl  
  perl >= 1:5.010
  perl(:MODULE_COMPAT_5.10.0)  
  perl(Carp)  
  perl(Cwd)  
  perl(Encode)  
  perl(English)  
  perl(Exporter)  
  perl(File::Basename)  
  perl(File::Spec)  
  perl(Getopt::Long)  
  perl(Moose) >= 0.67
  perl(Readonly)  
  perl(Readonly) >= 1.03
  perl(STD)  
  perl(Syntax::Highlight::Perl6)  
  perl(Term::ANSIColor)  
  perl(YAML::Syck) >= 1.05
  perl(feature)  
  perl(open)  
  perl(overload)  
  perl(strict)  
  perl(utf8)  
  perl(warnings)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

+ %check is present and all tests pass, though Text::VimColor needs to be
  packaged to complete the suite:
  t/00-syntax.t .... ok
  t/01-vim.t ....... skipped: Text::VimColor is not installed
  t/02-hilitep6.t .. ok
  All tests successful.
  Files=3, Tests=66, 11 wallclock secs ( 0.03 usr  0.01 sys +  3.06 cusr  0.16
csys =  3.26 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.