[Bug 495693] Review Request: perl-Syntax-Highlight-Perl6 - Perl 6 Syntax Highlighter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495693





--- Comment #2 from Marcela Maslanova <mmaslano at redhat.com>  2009-04-16 09:45:02 EDT ---
> - license field could be complicated
>   This library also includes the following libraries:
>   STD.pm by Larry Wall (Artistic License 2.0)
>   JQuery by John Resig (dual licensed under the MIT and GPL licenses).
> 
>   more like (GPL+ or Artistic) and Artistic 2.0 and (MIT or GPLv2) ?
> 
It looks like all of them are needed.

> - package installs properly.
>   Error: Missing Dependency: perl(STD) is needed by package
This is fixed by providing perl(STD) in this package.

> perl-Syntax-Highlight-Perl6-0.040-1.fc11.noarch
> (perl-Syntax-Highlight-Perl6-0.040-1.fc11.noarch.rpm)
> 
> - rpmlint has complaints:
>   perl-Syntax-Highlight-Perl6.noarch: E: non-executable-script
> /usr/lib/perl5/vendor_perl/5.10.0/Cursor.pmc 0644
Other scripts in this directory aren't executable.

> - final provides are missing (Cursor) and (STD)
Cursor should be used only as internal part, so it shouldn't be provided? 

>   t/01-vim.t ....... skipped: Text::VimColor is not installed
I'll made a review ticket for this requirement and then upload new package with
koji build.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.