[Bug 510668] Review Request: canorus - Music Score Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510668





--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-07-10 16:12:48 EDT ---
(In reply to comment #1)
> Just a few drive-by comments:
> 
> - Shouldn't the menu image go to %{_datadir}/pixmaps? Then you could drop the
> hicolor stuff.
> 

I once heard that %{_datadir}/pixmaps is being deprecated, and new stuff should
go into the hicolor directory.

> - Is the %{_datadir}/%{name}/doc directory accessed by the executable? Is the
> documentation in that directory human-readable? If yes, I suggest putting the
> doc/ directory in %doc and replacing %{_datadir}/%{name}/doc with a symlink to
> %{_docdir}/%{name}-%{version}/doc/, thus simplifying
>  %doc %{_datadir}/%{name}/doc/
>  %dir %{_datadir}/%{name}/
>  %{_datadir}/%{name}/examples/
>  %{_datadir}/%{name}/fonts/
>  %{_datadir}/%{name}/images/
>  %{_datadir}/%{name}/plugins/
>  %{_datadir}/%{name}/scripts/
> to
>  %doc doc/ (or whatever is the location of the docs in the source tree)
>  %{_datadir}/%{name}/
> 

The docs are in the Qt format and afaik they can't be read externally. They can
be read through the software only, by going Help->User's guide

I can also build the PDF docs. But these will be identical to the Qt docs. And
I think, from a users perspective, it is more convenient to access them through
the software itself.

> - The install command
>  DESTDIR=%{buildroot} make install DESTDIR=%{buildroot}
> has one DESTDIR too much :) You should be able to drop the former one.  

Ah, yes. I was testing stuff and I forgot to clean that up. Thanks for
pointing!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.