[Bug 491875] Review Request: unzoo - ZOO archive extractor

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 25 07:16:09 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491875





--- Comment #6 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-03-25 03:15:48 EDT ---
(In reply to comment #5)
> (In reply to comment #3)
> > - optflags are not used. Use
> > gcc %{optflags} -o unzoo -DSYS_IS_UNIX -O unzoo.c
> > in the build phase.
> 
> One comment:
> "-O" overwrites "-O2" optimization level used in %optflags,
> so when using %optflags "-O" argument should be removed.  

Right you are: only the value of the last argument is used. Thanks.

John: Please remove the -O flag, since %{optflags} already contain the
necessary optimizations.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list