[Bug 491886] Review Request: xa - 6502/65816 cross assembler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491886


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #1 from Till Maas <opensource at till.name>  2009-03-31 07:46:27 EDT ---
- %{_prefix} should be used instead of /usr in %install
- Instead of the chmod a-x for the manpages, you could fix the Makefile to use
install -m 0644 for the manpages.
- you should pass "INSTALL=install -p" to make, to preserve the timestamps of
the manpages
- can you maybe convince upstream to use PREFIX instead of DESTDIR for the
prefix (/usr/local), but add a $(DESTDIR) in install: to follow common
practice?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.