[Bug 526126] Review Request: python3 - Python 3.x (backwards incompatible version)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526126





--- Comment #39 from Toshio Ernie Kuratomi <a.badger at gmail.com>  2009-10-30 20:14:13 EDT ---
Python 3.* isn't very standard across packages.  Since we're saying that
python2 and python3 are different language versions, I think we should use
Python 3 (or Python3) in the descriptions.


We're unconditionally BuildRequireing openssl-devel so why are we
conditionalizing this:
  if pkg-config openssl ; then
    export CFLAGS="$CFLAGS `pkg-config --cflags openssl`"
    export LDFLAGS="$LDFLAGS `pkg-config --libs-only-L openssl`"
  fi


We don't need this::
  [ -d $RPM_BUILD_ROOT ] && rm -fr $RPM_BUILD_ROOT


Change this::
  - mkdir -p $RPM_BUILD_ROOT/usr $RPM_BUILD_ROOT%{_mandir}
  + mkdir -p $RPM_BUILD_ROOT%{_prefix} $RPM_BUILD_ROOT%{_mandir}


Why do we still have this in the spec file?  there's more and more work being
done on utilizing the information in the egg-info metadata so I don't think we
can keep removing it and stay compatible with upstream's intentions::
  # Get rid of egg-info files (core python modules are installed through rpms)
  rm $RPM_BUILD_ROOT%{pylibdir}/*.egg-info


Unless there's a good reason we probably want to make this change::
  # Switch all shebangs to refer to the specific Python version.
  - LD_LIBRARY_PATH=. ./python Tools/scripts/pathfix.py -i "%{_bindir}/env
python%{pybasever}" $RPM_BUILD_ROOT
  + LD_LIBRARY_PATH=. ./python Tools/scripts/pathfix.py -i
"%{_bindir}/python%{pybasever}" $RPM_BUILD_ROOT


What files are affected here?
  # Remove shebang lines from .py files that aren't executable
I just glanced at python2.6 and saw several different kinds of files that this
falls to:
  difflib.py - can run a unittest.. no harm done
  unittest.py - can be run as a script and do something useful
For find out which this is you have to check what the file does when run as a
script.


.cvsignore removal shouldn't be needed anymore as upstream hasswitched to svn
and then to hg.  remove lines like this::
  find $RPM_BUILD_ROOT/ -name ".cvsignore"|xargs rm -f
  find . -name ".cvsignore"|xargs rm -f


Fedora standard has %post and %postun before %files.


I'd like us to think about installing rpm macros like python_sitelib from this
and the main python package so we don't have to add it as boilerplate to each
spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.