[Bug 579171] Review Request: lxpolkit - Simple PolicyKit authentication agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=579171

--- Comment #3 from Christoph Wickert <cwickert at fedoraproject.org> 2010-04-04 17:46:44 EDT ---
(In reply to comment #2)
> 
> 1. Your git checkout comment has the wrong repo in it. ;) 

Copy & paste... I will fix this before building.

> lxpolkit.src:27: W: unversioned-explicit-provides
> PolicyKit-authentication-agent
> 
> Should that be versioned? I would guess not.

Right, this is a virtual provides, so no versioning. We will get fun with that
one anyway: compared to polkit-gnome or polkit-kde, lxpolkit is the shortest
name and will be pulled in by yum. All desktop files in autostart will need
"OnlyShowIn=..." so that only one agent gets started in each desktop.

I think it makes sense if the people using a legacy window manager like openbox
or alike will get lxshortcut instead of a GNOME or KDE specific agent. But I
will discuss this on f-d-l since we need to coordinate the updates.

> lxpolkit.x86_64: W: conffile-without-noreplace-flag
> /etc/xdg/autostart/lxpolkit.desktop
> 
> Should this be config(noreplace)?

I guess not. We want translation updates or a change in the path to appear
there and changes like en/disabling the autostart are done in the private
autostart ~/.config/autostart/ anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.