[Bug 597681] Review Request: kupfer - A free software launcher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597681

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |593800

--- Comment #4 from Michael Schwendt <mschwendt at gmail.com> 2010-08-05 07:17:31 EDT ---
> %files -f INSTALLED_FILES
> %defattr(-,root,root,-)
> %doc

This is not good, but sloppy. Using a files-list with option -f ought to be the
exceptional case, not the default. Do fill the %files section explicitly with
entries for directories and files found in the buildroot.


> Summary: kupfer is a simple, flexible, launcher for Gnome

Repeating the package name in the %summary only occupies space and makes the
summary less concise, because wherever the %summary would be displayed, the
package name or file name would be nearby (notice e.g. how Anaconda displays
the package summaries during installating). Better:

Summary: Simple but flexible launcher for GNOME

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.