[Bug 588477] Review Request: rubygem-webmock - mock object support for web dev in ruby.

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 30 01:52:20 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588477

Michael Stahnke <mastahnke at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mastahnke at gmail.com

--- Comment #2 from Michael Stahnke <mastahnke at gmail.com> 2010-08-29 21:52:19 EDT ---
rubygem-sitelib is never used and should be removed. 

rubygem-webmock.noarch: E: version-control-internal-file
/usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.gitignore



This can be removed rubygem-webmock.noarch: W: hidden-file-or-dir
/usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.document

I'd like to have a full %check section, but it looks like the Rakefile requires
jeweler.  There is a review bug open on that gem, and hopefully it will be
included soon.  Until then, perhaps having a %check section that is commented
out would be ok.

%check
cd %{buildroot}%{geminstdir}
rake test
rake spec

I'll have more comments after I review addressable and httpclient.  I open this
one in the wrong order.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list