[Bug 588428] Review Request: rubygem-addressable - Imporved URI/URL handling

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588428

Michael Stahnke <mastahnke at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mastahnke at gmail.com

--- Comment #1 from Michael Stahnke <mastahnke at gmail.com> 2010-08-29 22:16:51 EDT ---
builds in mock
rpmlint is clean

%ruby_sitelib should be removed, as it is not used.


You could add a %check

%check
cd %{buildroot}%{geminstdir}
rake spec


There isn't really a reason to do this. You can simply mark the normally
installed README file a %doc.  
mkdir -p %{buildroot}/usr/share/doc/%{gemdir}-%{version}
mv  %{buildroot}%{geminstdir}/README
%{buildroot}/usr/share/doc/%{gemdir}-%{version}

I'd also encourage you to break this package into a separate -doc package. It
would allow someone wishing to use addressable as a dep to not install about
3/4 of the total files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.