[Bug 657948] Review Request: launchy - open source keystroke launcher inspired by MacOS Quicksilver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657948

--- Comment #2 from Miroslav Suchý <msuchy at redhat.com> 2010-12-13 09:36:31 EST ---
missing buildrequires: gcc-c++
Please try to build in koji as scretch build to find possible missing build
requires.

rpmlint -i /home/mirek/rpmbuild/RPMS/i686/launchy-2.5-2.fc14.i686.rpm
launchy.i686: E: explicit-lib-dependency libX11
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

launchy.i686: W: no-manual-page-for-binary launchy
Each executable in standard binary directories should have a man page


even without specifying  libX11 you automatically get libX11.so.6 as
requirement.
The same probably apply on qt, rpmbuild will give you:
libQtCore.so.4  
libQtGui.so.4  
libQtNetwork.so.4
so you most probably do not need to require qt and qt-x11, you "just" need
those 3 libraries.


you use there once /usr/share, you may want to replace it with: %{_datadir}

Apart from this it seems ok (for first sight).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.