[Bug 663653] Review Request: rubygem-warden - Rack middle-ware that provides authentication

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663653

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-12-17 13:47:07 EST ---
Some notes:

* BuildRoot tag
  - BuildRoot: line is no longer needed on Fedora:
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* Requires
  - rubygem(rack) is needed only for BuildRequires and not needed
    for Requires
  - Remove unneeded ">= 1" or ">= 1.0.0" parts on
    (Build)Requires: rubygem-foo. c.f.
    https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

* Cleaning
  - "rm -rf %{buildroot}" at the top of %install, %clean section
    are no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* Consistent path usage
  - Why do you add %_bindir/ before spec explicitly while you don't
    write /bin/rm or %_bindir/gem?

* Splitting out document files
  - Please consider to create -doc subpackage and move the following
    files / directories into -doc
---------------------------------------------------
%{geminstdir}/spec
%{geminstdir}/warden.gemspec
%{geminstdir}/Rakefile
%{gemdir}/doc/%{gemname}-%{version}
---------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.