[Bug 663653] Review Request: rubygem-warden - Rack middle-ware that provides authentication

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 20 09:44:41 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663653

--- Comment #2 from Vít Ondruch <vondruch at redhat.com> 2010-12-20 04:44:40 EST ---
Thank you for your review. I have uploaded new versions here:

Spec URL: http://people.redhat.com/vondruch/rubygem-warden.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-warden-1.0.3-2.fc14.src.rpm

However, I did not removed the "Requires: rubygem(rack)" as you suggested. My
reasons are:
1) Warden is Rack middle-ware, therefore it should depend on rack during
runtime. Usage of warden without rack doesn't make too much sense.
2) Although there is not explicit "require 'rack'" in lib folder, there are
references on "Rack" module. Developing some web application, there is high
chance that some body did that require before warden had a chance (this might
be considered as really minor bug of warden?).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list